C: Use hb_string_T when initializing new tokens#798
Merged
Conversation
timkaechele
force-pushed
the
token-init-hb-string
branch
from
b90871a to
1e43834
Compare
marcoroth
pushed a commit
that referenced
this pull request
Nov 8, 2025
Based on the changes made in #798 this PR changes the remaining functions in the lexer to use `hb_string_T`.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of the
token_initfunction to takehb_string_Tinstead of a raw string.The token still stores its value as a
char *. This PR just changes the interface for initializing tokens.The call sites in the lexer are adapted to the new
token_initsignature and buffer usages are minimized.Newly introduced functions
hb_string_rangea function that allows to get a substring from a given stringhb_string_to_c_string_using_malloca version ofhb_string_to_c_stringthat doesn't rely on the arena allocator. (Necessary since we don't have widespread use of the arena allocator yet)